From 874bce4b74f2154a2a79f18732fcdb98ff1864bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20H=C3=BCbelbauer?= Date: Tue, 28 Feb 2023 17:17:44 +0100 Subject: [PATCH] Accept uppercase LGTM as one of the default triggers Hi! I always forget the `lgtm` in the default trigger is lowercase. I know I can override the trigger but I'm thinking maybe you'll want to accept uppercase `LGTM` as one of the default triggers? Even this repository's description uses the uppercase variant in a few cases including the README picture so I think it might make sense? WDYT? BTW as far as I can tell this shouldn't already work because the regex case-insensitive flag in the default input string is missing and `parseTrigger` doesn't add it but if it already does work maybe the problem is just with our setup. I don't use Go so I just followed what I learnt on SO in terms of how to make a pattern case-insensitive. --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 0863415..bd0fd66 100644 --- a/action.yml +++ b/action.yml @@ -5,7 +5,7 @@ inputs: trigger: description: 'Trigger comment on issue to send reaction' required: false - default: '["^lgtm$", "^[gG]ood [jJ]ob!?$"]' + default: '["(?i)^lgtm$", "^[gG]ood [jJ]ob!?$"]' overide: description: 'Whether the original comment is overridden' required: false