Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simulation] Use normalization like in the demo. #135

Open
juharris opened this issue Nov 30, 2021 · 2 comments
Open

[simulation] Use normalization like in the demo. #135

juharris opened this issue Nov 30, 2021 · 2 comments
Labels
enhancement New feature or request simulation Relates to the Python code to run simulations

Comments

@juharris
Copy link
Contributor

juharris commented Nov 30, 2021

In the demo, normalization is done before updating the dense perceptron and dense nearest centroid classifiers, but the simulation doesn't use normalization.

Normalization is used to avoid submissions with large values that would corrupt the model. Using normalized vectors might be bad for these models but it seems like a necessary guard to have on-chain.

@juharris juharris added enhancement New feature or request simulation Relates to the Python code to run simulations labels Nov 30, 2021
@hs094
Copy link

hs094 commented Mar 7, 2022

Can you describe more about this Issue?

@juharris
Copy link
Contributor Author

juharris commented Mar 7, 2022

We enforce that data in normalized before adding in DensePerceptron.sol and some other classes in the demo folder but we don't normalize data before processing it in the simulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request simulation Relates to the Python code to run simulations
Projects
None yet
Development

No branches or pull requests

2 participants