-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#179 #185
Closed
Closed
Issue#179 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moved DscResource name to specific class * rem SetStigRuleResource * fixed SetStigRuleResource * removed class definition tests * moved methods to class * fixed dscresource * added SetDscResource method * formatting * added SetDscResource * added CheckContent
* rename AccountPolicyRule * rem Get-RuleTypeMatchList * renamed AuditPolicyRule Module * rename DnsServerRootHintRule module * rename DnsServerSettingRule module * rename DocumentRule module * rename FileContentRule module * rename GroupRule module * rename IISLoggingRule module * rename ManualRule module * rename MimeTypeRule module * rename PermissionRule module * rename ProcessMitigationRule module * rename RegistryRule module * rename SecurityOptionRule module * rename ServiceRule module * rollback rem Convert.RegistryRule * rollback rem Convert.RegistryRule * rollback ServiceRule rename * rolled back rename * fixed name * renamed RegistryRule module * rollback rename * rem template * rename WmiRule module * formatting * moved strings * renamed Convert.PermissionRule module * renamed WinEventLogRule * renamed WindowsFeatureRule * Added unit test file * renamed ProcessMitigationRule * renamed RegistryRule * renamed SecurityOptionRule * renamed ServiceRule * renamed UserRightsAssignmentRule * renamed SqlScriptQueryRule * renamed WebAppPoolRule * renamed WebConfigurationPropertyRule * moved data sections * moved data sections * fixed data name * fixed variable names * fixed variable name * fixed rule * formatting * formatting * fixed tests
* fix description * add new unit tests * fix typo * fix formatting * minor fix * minor change * fix description * add new unit tests * fix formatting * minor fix * minor change * minor formatting * add new unit tests * fix formatting * minor fix * fix description * minor change * minor fix * minor formatting * minor formatting * removed tests for deleted functions * fix formatting
Codecov Report
@@ Coverage Diff @@
## dev #185 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 15 15
Lines 251 251
Branches 3 3
=======================================
Hits 201 201
Misses 47 47
Partials 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description:
This PR updates the logic in the Process Mitigation DSC resource call to return individual rules vs merging them and also updated the resource title to use the standard title function.
This Pull Request (PR) fixes the following issues:
This fixes #179
Task list:
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)