Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#179 #185

Closed
wants to merge 11 commits into from
Closed

Issue#179 #185

wants to merge 11 commits into from

Conversation

athaynes
Copy link
Contributor

@athaynes athaynes commented Nov 5, 2018

Pull Request (PR) description:

This PR updates the logic in the Process Mitigation DSC resource call to return individual rules vs merging them and also updated the resource title to use the standard title function.

This Pull Request (PR) fixes the following issues:

This fixes #179

Task list:

  • Change details added to Unreleased section of README.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

athaynes and others added 11 commits October 19, 2018 09:00
* moved DscResource name to specific class

* rem SetStigRuleResource

* fixed SetStigRuleResource

* removed class definition tests

* moved methods to class

* fixed dscresource

* added SetDscResource method

* formatting

* added SetDscResource

* added CheckContent
* rename AccountPolicyRule

* rem Get-RuleTypeMatchList

* renamed AuditPolicyRule Module

* rename DnsServerRootHintRule module

* rename DnsServerSettingRule module

* rename DocumentRule module

* rename FileContentRule module

* rename GroupRule module

* rename IISLoggingRule module

* rename ManualRule module

* rename MimeTypeRule module

* rename PermissionRule module

* rename ProcessMitigationRule module

* rename RegistryRule module

* rename SecurityOptionRule module

* rename ServiceRule module

* rollback rem Convert.RegistryRule

* rollback rem Convert.RegistryRule

* rollback ServiceRule rename

* rolled back rename

* fixed name

* renamed RegistryRule module

* rollback rename

* rem template

* rename WmiRule module

* formatting

* moved strings

* renamed Convert.PermissionRule module

* renamed WinEventLogRule

* renamed WindowsFeatureRule

* Added unit test file

* renamed ProcessMitigationRule

* renamed RegistryRule

* renamed SecurityOptionRule

* renamed ServiceRule

* renamed UserRightsAssignmentRule

* renamed SqlScriptQueryRule

* renamed WebAppPoolRule

* renamed WebConfigurationPropertyRule

* moved data sections

* moved data sections

* fixed data name

* fixed variable names

* fixed variable name

* fixed rule

* formatting

* formatting

* fixed tests
* fix description

* add new unit tests

* fix typo

* fix formatting

* minor fix

* minor change

* fix description

* add new unit tests

* fix formatting

* minor fix

* minor change

* minor formatting

* add new unit tests

* fix formatting

* minor fix

* fix description

* minor change

* minor fix

* minor formatting

* minor formatting

* removed tests for deleted functions

* fix formatting
@codecov-io
Copy link

codecov-io commented Nov 5, 2018

Codecov Report

Merging #185 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #185   +/-   ##
=======================================
  Coverage   80.07%   80.07%           
=======================================
  Files          15       15           
  Lines         251      251           
  Branches        3        3           
=======================================
  Hits          201      201           
  Misses         47       47           
  Partials        3        3
Impacted Files Coverage Δ
PowerStig.Convert.psm1 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20243ef...d610bcd. Read the comment docs.

@athaynes athaynes closed this Nov 12, 2018
@athaynes athaynes deleted the athaynes#179 branch November 12, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProcessMitigation ResourceID is created in an inconsistent format
3 participants