Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Windows Feature Rule parser to remove the external Data file #223

Open
athaynes opened this issue Dec 17, 2018 · 1 comment
Open
Assignees
Milestone

Comments

@athaynes
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The Get-WindowsFeatureName function in the WindowsFeatureRule module does not take advantage of
the switch statement regex capability nor do the regex patterns leverage capturing groups.

Describe the solution you'd like

The switch statement should be updated to use regex more efficiently or removed all together and replaced with a single regex with a capturing group. Updating the switch using the following example and move all naming correction in the rest of the switch to a separate task.

switch -Regex ($checkContent -split '\n')
{
    $regularExpression.WindowsFeatureName { $windowsFeatureName += $matches['featureName']}
}

Describe alternatives you've considered

Additional context

@athaynes athaynes self-assigned this Jan 17, 2019
@athaynes
Copy link
Contributor Author

That has been started in PR #206 but still has a bit of clean up and consolidation that needs to happen before it is closed.

@athaynes athaynes changed the title WindowsFeatureRuleConvert regex is inefficient. Update the Windows Feature Rule parser to remove the external Data file Feb 14, 2019
@athaynes athaynes added this to the 3.1.0 milestone Mar 1, 2019
@athaynes athaynes modified the milestones: 3.1.0, 3.2.0 Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant