-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List of syntactic definition file errors we could detect #9027
Comments
Just an opinion, but this sounds more like a linter error than a syntax error. Not saying it's a bad idea to warn, but I would disagree about it being something that should be completely rejected. |
@isiahmeadows the intention here is to implement these as tslint rules and suggest them for definition authors, and may be run them on definitelytyped CI. |
@mhegazy Oh. Okay. I get what you mean. |
Non-consecutive function overloads in the same blockinterface Foo {
x(): void;
y(): void;
x(s: string): number; // <-- error, all 'x' signatures should be adjacent
} |
@rakatyal can we mark this as completed? |
These should all be addressed now in https://github.com/Microsoft/dtslint |
Signatures that differ only by a single parameter type
Signatures that differ only by omitting by a parameter
Use of the non-primitive names anywhere
(except in a
interface Number {
declaration)Optional parameters in callback positions:
The text was updated successfully, but these errors were encountered: