Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ElasticSearch Connector doesn't respect limit or minRelevance parameters #934

Open
basyonic opened this issue Dec 10, 2024 · 2 comments
Labels
bug Something isn't working waiting for author Waiting for author to reply or address comments

Comments

@basyonic
Copy link

Context / Scenario

Steps to reproduce:

  • Configure Kernel Memory ElasticSearch Connector
  • Ingest document
  • Use GetSimilarListAsync and pass limit and minRelevance Parameters

Expected
Limits and minRelevance are respected with max number of result match limit parameter and minRelevance Score match passed parameter

What happened?

Limits and minRelevance are not respected.
API always return max of 15 results with any relevance score

Importance

I cannot use Kernel Memory

Platform, Language, Versions

Kernel Memory 0.94.241201.1

Relevant log output

@basyonic
Copy link
Author

Bug fix in the below PR
#935

@dluc
Copy link
Collaborator

dluc commented Dec 18, 2024

@basyonic

API always return max of 15 results with any relevance score

which API do you mean here? The Memory API should return the exact number requested. Looks like you're using the connector directly, bypassing the memory API.

I left some comments in the PR, there are also bugs in the way the relevance score is handled.

@dluc dluc added waiting for author Waiting for author to reply or address comments and removed triage labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting for author Waiting for author to reply or address comments
Projects
None yet
Development

No branches or pull requests

2 participants