Replies: 3 comments
-
This looks like it is an issue specific to |
Beta Was this translation helpful? Give feedback.
-
Angular appears to have no plans to change this behavior in the build optimizer. You need to turn off the build optimizer, or have the optimizer ignore Monaco. However, if the error stems from not following best practices (e.g, object property access should be side-effect free), it could be worthwhile to explore changing Monaco so it plays nicely with uglifyjs. It could benefit the maintainability of Monaco, since developers working on Monaco could unintentionally assume those best practices are valid here. Both sides present valid arguments. Angular shouldn't impose assumptions on third-party library code, but also making changes to conform to those fairly reasonable assumptions could be overall beneficial to maintainers. |
Beta Was this translation helpful? Give feedback.
-
Ignoring the tree shaking optimization for the Monaco Editor sounds reasonable. The Monaco Editor is shipped from "tree shaken" VS Code sources -- see here |
Beta Was this translation helpful? Give feedback.
-
monaco-editor version: 0.18.1
**Browser:chrome
**OS:win10
Steps or JS usage snippet reproducing the issue:
The problem in this issues
It's not my issues but I have the same with it.
error-demourl
When I run with
ng serve
the monaco has no bugBut When I run with
ng serve --prod
(production mode),the monaco has bug on ConsoleI think the bug belong to
angular-cli
ormonaco
,but inangular-cli
,past few months, it's not fixed.So I hopemonaco
can see it and give a solution.Beta Was this translation helpful? Give feedback.
All reactions