From c1bc92f4d444f9192459d51bbad24672896426c7 Mon Sep 17 00:00:00 2001
From: Evan Baker <rbtr@users.noreply.github.com>
Date: Mon, 2 Dec 2024 15:11:39 -0600
Subject: [PATCH] fix: name flag dereference (#1095)

# Description

Fixes NPE related to uninstantiated `Name` pointer

## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

---------

Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
---
 cli/cmd/capture/capture.go |  4 +++-
 cli/cmd_test.go            | 33 +++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 cli/cmd_test.go

diff --git a/cli/cmd/capture/capture.go b/cli/cmd/capture/capture.go
index be24da8f25..c7c6861b12 100644
--- a/cli/cmd/capture/capture.go
+++ b/cli/cmd/capture/capture.go
@@ -12,7 +12,9 @@ import (
 var opts = struct {
 	genericclioptions.ConfigFlags
 	Name *string
-}{}
+}{
+	Name: new(string),
+}
 
 const defaultName = "retina-capture"
 
diff --git a/cli/cmd_test.go b/cli/cmd_test.go
new file mode 100644
index 0000000000..ef5802801f
--- /dev/null
+++ b/cli/cmd_test.go
@@ -0,0 +1,33 @@
+package main
+
+import (
+	"bytes"
+	"testing"
+
+	"github.com/microsoft/retina/cli/cmd"
+	"github.com/spf13/cobra"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func ExecuteInTest(cmd *cobra.Command, args []string) (stdout string, stderr string, err error) {
+	var stdoutBuf, stderrBuf bytes.Buffer
+	cmd.SetArgs(args)
+	cmd.SetOut(&stdoutBuf)
+	cmd.SetErr(&stderrBuf)
+	defer func() {
+		cmd.SetArgs(nil)
+		cmd.SetOut(nil)
+		cmd.SetErr(nil)
+	}()
+
+	err = cmd.Execute()
+	return stdoutBuf.String(), stderrBuf.String(), err
+}
+
+func TestCLICmd(t *testing.T) {
+	stdout, stderr, err := ExecuteInTest(cmd.Retina, []string{"-h"})
+	require.NoError(t, err)
+	assert.Contains(t, stdout, "kubectl-retina")
+	assert.Equal(t, stderr, "")
+}