Python: Fix pydantic alias issue #10027
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the alias as pydantic requires the usage of the alias when initializing the class not the original name which prevents this code from working.
```py
cosmosdb_settings = AzureCosmosDBSettings.create(
env_file_path=env_file_path,
connection_string=cosmos_connstr,
)
```
markwallace-microsoft
added
python
github-actions
bot
changed the title
python/semantic_kernel/connectors/memory/azure_cosmosdb/azure_cosmosdb_settings.py
Show resolved
Hide resolved
john0isaac
commented
Dec 30, 2024
python/semantic_kernel/connectors/memory/azure_cosmosdb/azure_cosmosdb_settings.py
Outdated
Show resolved
Hide resolved
forr pydantic 2.0
|
@eavanvalkenburg done, i tested it with my sample and it's working. |
|
There is a bug in a dependency, I've raised an issue for it: milvus-io/milvus-lite#242 |
|
and also created a seperate PR for it, now just need to find some approvers! |
moonbox3
approved these changes
Jan 3, 2025
Python Test Coverage Report •
Python Unit Test Overview
|
python/semantic_kernel/connectors/memory/azure_cosmosdb/azure_cosmosdb_settings.py
Show resolved
Hide resolved
eavanvalkenburg
approved these changes
Jan 3, 2025
python/semantic_kernel/connectors/memory/azure_cosmosdb/azure_cosmosdb_settings.py
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
January 4, 2025 14:26
Head branch was pushed to by a user without write access
eavanvalkenburg
approved these changes
Jan 4, 2025
eavanvalkenburg
force-pushed
the
fix-mongo-settings
branch
from
278b5d7 to
ba119ac
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@eavanvalkenburg I will debug it and let you know the issue. |
john0isaac
force-pushed
the
fix-mongo-settings
branch
from
ba119ac to
6239045
Compare
|
no need, we have some intergration tests that just fail randomly, so sometimes takes one or two attempts |
|
I just noticed that it's a different test that fails each time 😆 |
|
merged now! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fix #10026
Description
This PR removes the alias as pydantic requires the usage of the alias when initializing the class not the original name which prevents this code from working.
Contribution Checklist