Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net Agents - History Management Consistency: ChatCompletionAgent #8856

Open
crickman opened this issue Sep 17, 2024 · 1 comment
Open

.Net Agents - History Management Consistency: ChatCompletionAgent #8856

crickman opened this issue Sep 17, 2024 · 1 comment
Assignees
@crickman
Labels
agents enhancement experimental Associated with an experimental feature .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@crickman
Copy link
Contributor

The direction invocation (no chat) case for ChatCompletionAgent requires the user to manually update the ChatHistory with the agent response. This isn't required for the streaming case or any usage of OpenAIAssistantAgent.

Even worse, the Termination scenario for IAutoFunctionInvocationFilter and manual function calling cases require complex, non discoverable logic to avoid introducing invalid changes to the ChatHistory.

Having ChatCompletionAgent.InvokeAsync fully manage the history not only is consistent with the rest of the Agent Framework, it solves this advance, non-discoverable cases.
@crickman crickman added .NET Issue or Pull requests regarding .NET code agents experimental Associated with an experimental feature triage labels Sep 17, 2024
@crickman crickman self-assigned this Sep 17, 2024
@crickman crickman moved this to Sprint: In Progress in Semantic Kernel Sep 17, 2024
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Sep 18, 2024
@crickman crickman moved this from Sprint: In Progress to Backlog in Semantic Kernel Oct 21, 2024
@crickman
Copy link
Contributor Author

As breaking behavior change, perhaps introduce a setting that allows caller to opt-into an improved pattern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crickman crickman

Labels
agents enhancement experimental Associated with an experimental feature .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evchaki @crickman @markwallace-microsoft