Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net Agents - OpenAIAssistantAgent.InvokeStreamingAsync: ChatHistory (messages) parameter not optional. #8857

Closed
crickman opened this issue Sep 17, 2024 · 0 comments · Fixed by #8915
Closed

.Net Agents - OpenAIAssistantAgent.InvokeStreamingAsync: ChatHistory (messages) parameter not optional. #8857

crickman opened this issue Sep 17, 2024 · 0 comments · Fixed by #8915
Assignees
@crickman
Labels
agents enhancement experimental Associated with an experimental feature .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@crickman
Copy link
Contributor

This parameter provides convenience for cases where this is desired, but need not be required.

#8810

Note: Can also be positioned as the final parameter prior to CancellationToken
@crickman crickman added .NET Issue or Pull requests regarding .NET code agents enhancement experimental Associated with an experimental feature triage labels Sep 17, 2024
@crickman crickman self-assigned this Sep 17, 2024
@crickman crickman moved this to Sprint: In Progress in Semantic Kernel Sep 17, 2024
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Sep 18, 2024
@crickman crickman moved this from Sprint: In Progress to Sprint: In Review in Semantic Kernel Sep 19, 2024
@crickman crickman mentioned this issue Sep 19, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
@crickman
.Net Agents - Make messages parameter optional for `OpenAIAssistant…
6bba2b6 
…Agent.InvokeStreamingAsync` (#8915)

### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Customer input identified that `messages` parameter may not always be
required by the caller.

Fixes: #8857

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Providing the complete messages is a convenience and shouldn't be
required.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
@github-project-automation github-project-automation bot moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crickman crickman

Labels
agents enhancement experimental Associated with an experimental feature .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
3 participants
@evchaki @crickman @markwallace-microsoft