-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: New Feature: KernelAgent - Update the Template property #9186
Comments
@mickaelropars - Thanks for this input. Exposing the |
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Fixes: #9072 Fixes: #9186 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> The channel-key definition resulted in a hash that resulted in every `AggregtorAgent` sharing the same channel. This overlap in chat management interfere's with the desired isolation. Also including a change to the scope of `KernelAgent.Template` property to that its exposed to the caller (customer request) ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
@crickman , thanks a lot for your advice I will implement the prompt render filtering to get the content of the rendered prompt within our logs. The template visibility change will help me when creating an agent to display prompt rendering when building the template (custom user agent creation) . Currently waiting for the unsealed agent class in order to build it. |
name: Feature request
in kernelAgent class the Template property is protected
it can be usefull to render the template of an agent . in order to see that the prompt is well formated.
Is it possible to change the visibility of Template in KernelAgent?
The text was updated successfully, but these errors were encountered: