Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: .Net: Bug: Missing 'List' method in IVectorStoreRecordCollection, cannot resync collection from source #9892

Open
tlecomte opened this issue Dec 5, 2024 · 0 comments
Assignees
Labels
memory connector memory .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel

Comments

@tlecomte
Copy link

tlecomte commented Dec 5, 2024

Describe the bug
IVectorStoreRecordCollection does not have a method to list all the keys stored in the collection. So we are missing a way to compare the content of the collection with the source to find what keys are to be deleted (when they are no longer in the source data).

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/microsoft/semantic-kernel/blob/main/dotnet/src/Connectors/VectorData.Abstractions/VectorStorage/IVectorStoreRecordCollection.cs
  2. Observe that there are methods to get by key, delete by key, upsert by key, but no method to list all keys

Expected behavior
We would expect to have something like IVectorStoreRecordCollection.ListAsync. That would allow to find what keys need to be deleted.

Screenshots
N/A

Platform

  • OS: all
  • IDE: N/A
  • Language: C#
  • Source: main branch of repository

Additional context
N/A

@tlecomte tlecomte added the bug Something isn't working label Dec 5, 2024
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Dec 5, 2024
@github-actions github-actions bot changed the title Bug: Missing 'List' method in IVectorStoreRecordCollection, cannot resync collection from source .Net: Bug: Missing 'List' method in IVectorStoreRecordCollection, cannot resync collection from source Dec 5, 2024
@markwallace-microsoft markwallace-microsoft added memory connector memory and removed bug Something isn't working triage labels Dec 9, 2024
@sphenry sphenry added python Pull requests for the Python Semantic Kernel and removed triage labels Dec 9, 2024
@github-actions github-actions bot changed the title .Net: Bug: Missing 'List' method in IVectorStoreRecordCollection, cannot resync collection from source Python: .Net: Bug: Missing 'List' method in IVectorStoreRecordCollection, cannot resync collection from source Dec 9, 2024
@markwallace-microsoft markwallace-microsoft moved this from Backlog to Sprint: Planned in Semantic Kernel Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory connector memory .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel
Projects
Status: Sprint: Planned
Development

No branches or pull requests

4 participants