Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos and accessibility no-nos #224

Closed
jsoref opened this issue Dec 12, 2024 · 0 comments · Fixed by #223
Closed

Typos and accessibility no-nos #224

jsoref opened this issue Dec 12, 2024 · 0 comments · Fixed by #223
Labels
nice to have This is not required, but would be nice to have
Milestone
vNext

Comments

@jsoref
Copy link
Contributor

jsoref commented Dec 12, 2024

Describe the bug
Typos as well as using things like here for links make it harder for readers to understand code.

To Reproduce
Steps to reproduce the behavior:

  1. Set up check-spelling
  2. View the results

Expected behavior
No errors relating to typos or forbidden patterns.

Additional context
This project is used by winget-cli which uses check-spelling. When I sent an upgrade for it, I was advised that I could send upstream fixes microsoft/winget-cli#5045 (comment).
@jsoref jsoref mentioned this issue Dec 12, 2024
Merged
@arthuraraujo-msft arthuraraujo-msft added the nice to have This is not required, but would be nice to have label Dec 12, 2024
@arthuraraujo-msft arthuraraujo-msft added this to the vNext milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice to have This is not required, but would be nice to have
Projects
None yet
Milestone
vNext
Development

Successfully merging a pull request may close this issue.

Fixing spelling issues within the codebase jsoref/sfs-client
2 participants
@jsoref @arthuraraujo-msft