Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Mixer Sound Setting not saved for Windows Terminal #17733

Open
mobeigi opened this issue Aug 17, 2024 · 4 comments
Open

Volume Mixer Sound Setting not saved for Windows Terminal #17733

mobeigi opened this issue Aug 17, 2024 · 4 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@mobeigi
Copy link

mobeigi commented Aug 17, 2024

Windows Terminal version

1.20.11781.0

Windows build number

10.0.19045.4780

Other Software

No response

Problem

My issue is I like to have my system sounds (including the bell) set to 10% of System Volume.
I have already customised the bell wav for my terminal profiles and this works well, its just the bell sound is too loud and I can't set it to 10% volume because Windows doesn't remember the volume mixer setting for Windows Terminal after it restarts (unlike other apps).

Some undesirable workarounds:

  • I know I can disable the bell via bellStyle but this is not what I want to do.
  • I know I can modify the bell sound wav audio itself to be much quieter but it seems like a hack.

Steps to reproduce

Current volume mixer:
image

These settings work perfectly for Command Prompt shell (my system sounds is at 10% and my bell sound is quiet).

However, for other WT profiles it does not work the same:

  1. Open wt up with a non Command Prompt profile (for example, I am using Git Bash)
  2. Trigger bell sound (i.e. via failed autocompletion etc). Windows Terminal now appears in volume mixer
  3. Set Windows Terminal volume to desired volume (i.e. 10%)
  4. Quit Windows Terminal
  5. Start Windows Terminal
  6. Trigger bell sound again (Volume is back to 100% in Volume Mixer)

Post volume mixer:
SndVol_PtOoxEF9oK

Expected Behavior

Volume remains the same as previously set value in Volume Mixer.

Actual Behavior

Volume is reset (back to 100%) in Volume Mixer.

@mobeigi mobeigi added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 17, 2024
@carlos-zamora
Copy link
Member

Thanks for filing! We're thinking this may be an app platform bug as it's fixed in Win11.

We're thinking this may also be fixed by using a different media player from the WinRT one. We've seen that doing that has fixed other issues (i.e. file picker issues).

@carlos-zamora carlos-zamora added this to the Backlog milestone Aug 21, 2024
@carlos-zamora carlos-zamora added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 21, 2024
@mobeigi
Copy link
Author

mobeigi commented Aug 22, 2024

We're thinking this may also be fixed by using a different media player from the WinRT one. We've seen that doing that has fixed other issues (i.e. file picker issues).

Thanks for the reply mate. Can you elaborate on the 'different media player' part? What does that mean exactly?
Do you have a link to other similar issues?

@zadjii-msft
Copy link
Member

Sure thing. We're using the "modern" WinRT MediaPlayer APIs to play bell sounds currently:

_bellPlayerCreated = true;
_bellPlayer = winrt::Windows::Media::Playback::MediaPlayer();
// GH#12258: The media keys (like play/pause) should have no effect on our bell sound.
_bellPlayer.CommandManager().IsEnabled(false);

But we've got a theory that the older, win32-style APIs for playing media probably don't have the same OS bug applicable to them. That's where we'd start investigating.

@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Aug 22, 2024
@SamusAranX
Copy link

as it's fixed in Win11.

I'm on Windows 11 (OS build 26100.2605, Terminal version 1.21.3231.0) and it's very much not fixed there.
Every time something in the terminal goes ding, the alert sound is played at a deafening volume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants