Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set alt+space as keybinding on lastest canary build #18371

Closed
e82eric opened this issue Dec 27, 2024 · 2 comments
Closed

Unable to set alt+space as keybinding on lastest canary build #18371

e82eric opened this issue Dec 27, 2024 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@e82eric
Copy link
Contributor

e82eric commented Dec 27, 2024

Windows Terminal version

terminal-1.23.3582.0

Windows build number

1.23.3582.0

Other Software

Windows 10

Steps to reproduce

Update Terminal.DuplicatePaneAuto in settings.json that comes with portable build to

        {
            "id": "Terminal.DuplicatePaneAuto",
            "keys": "alt+space"
        }

Expected Behavior

Pane to be duplicated

Actual Behavior

Nothing happens. (System menu also doesn't show)

@e82eric e82eric added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 27, 2024
@e82eric
Copy link
Contributor Author

e82eric commented Dec 27, 2024

It looks like this was introduced in 8bbf00e #18215

In the previous commit I would see TermControl::_KeyDownHandler fire when alt+space pressed, that no longer fired when I moved to 8bbf00e

I think it has to do with this method being removed but I wasn't quite sure how to try adding it back.
https://github.com/microsoft/terminal/pull/18215/files#diff-3b81ed111402e0dc05d8467fc9819ae836970109c26b252fa82019bebf1a8cd5L176

@e82eric
Copy link
Contributor Author

e82eric commented Dec 27, 2024

Duplicate of #18331

@e82eric e82eric closed this as completed Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

1 participant