Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null batchResponse when POSTing a batch request. #2255

Open
temt91 opened this issue Dec 19, 2024 · 0 comments
Open

null batchResponse when POSTing a batch request. #2255

temt91 opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels
type:bug A broken experience

Comments

@temt91
Copy link

temt91 commented Dec 19, 2024

Describe the bug

Caused by: java.lang.NullPointerException: The following parameter cannot be null: batchResponse
	at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]
	at com.microsoft.graph.core.content.BatchResponseContent.<init>(BatchResponseContent.java:42) ~[microsoft-graph-core-3.2.1.jar:?]
	at com.microsoft.graph.core.requests.BatchRequestBuilder.post(BatchRequestBuilder.java:53) ~[microsoft-graph-core-3.2.1.jar:?]
	at com.microsoft.graph.serviceclient.CustomBatchRequestBuilder.post(CustomBatchRequestBuilder.java:41) ~[microsoft-graph-6.16.0.jar:?]
	at com.microsoft.graph.core.requests.BatchRequestBuilder.post(BatchRequestBuilder.java:67) ~[microsoft-graph-core-3.2.1.jar:?]
	at com.microsoft.graph.serviceclient.CustomBatchRequestBuilder.post(CustomBatchRequestBuilder.java:53) ~[microsoft-graph-6.16.0.jar:?]
2024-11-21T16:05:58 WARNING [TOMCAT] okhttp3.internal.platform.Platform log okhttp3.OkHttpClient - A connection to https://graph.microsoft.com/ was leaked. Did you forget to close a response body? To see where this was allocated, set the OkHttpClient logger level to FINE: Logger.getLogger(OkHttpClient.class.getName()).setLevel(Level.FINE);

Our code started throwing a null pointer exception as shown in the logs. The code and requests normally run fine, however this error seems to have randomly occurred. Once we saw this error all subsequent requests to Azure also failed until the process was restarted.

Under what circumstances could this happen?

Expected behavior

Requests complete successfully. Failed requests should throw an ApiException?

How to reproduce

This does not occur under normal circumstances - the following code usually works fine.

We have seen the same error on two different underlying requests, wrapped in batch requests.
mGraphClient.users().byUserId(x).memberOf().graphGroup() and mGraphClient.groups().getByIds()

An example:

ClientSecretCredential vCredential = new ClientSecretCredentialBuilder().clientId(mClientId).tenantId(mTenantId).clientSecret(mClientSecret).build();
mGraphClient = new GraphServiceClient(vCredential, "https://graph.microsoft.com/.default");

-----
BatchRequestContentCollection vBatchRequest = new BatchRequestContentCollection(mGraphClient);
for (String vId : pIds) {
  RequestInformation vRequestInfo = mGraphClient.users().byUserId(vId).memberOf().graphGroup().toGetRequestInformation(requestConfiguration -> {
	  requestConfiguration.queryParameters.select = new String[] { ID };
	  requestConfiguration.queryParameters.top = MAX_PAGE_SIZE;
  });
  vBatchRequest.addBatchRequestStep(vRequestInfo);
}

BatchResponseContentCollection vBatchResponse = mGraphClient.getBatchRequestBuilder().post(vBatchRequest, null);

SDK Version

6.16.0

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output

Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_
@temt91 temt91 added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience labels Dec 19, 2024
@Ndiritu Ndiritu removed the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Dec 19, 2024
@Ndiritu Ndiritu self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A broken experience
Projects
None yet
Development

No branches or pull requests

2 participants