Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook/endpoint to create "incidents" in the system on-demand #558

Open
jayantbh opened this issue Oct 1, 2024 · 7 comments
Open

Webhook/endpoint to create "incidents" in the system on-demand #558

jayantbh opened this issue Oct 1, 2024 · 7 comments
Labels
advanced These are not really meant for beginners or brand new contributors, but feel free to give it a shot! enhancement New feature or request help wanted Extra attention is needed

Comments

@jayantbh
Copy link
Contributor

jayantbh commented Oct 1, 2024

Why do we need this ?

Currently the system relies on reverted PRs for CFR/MTTR data, only.
With support for webhooks, we might be able to link a variety of third party incident management solutions to Middleware for better Dora metrics reporting.

Should be straight-forward enough.

@jayantbh jayantbh added enhancement New feature or request help wanted Extra attention is needed hacktoberfest advanced These are not really meant for beginners or brand new contributors, but feel free to give it a shot! labels Oct 1, 2024
@xyfer17
Copy link
Contributor

xyfer17 commented Oct 5, 2024

@jayantbh could please assign this issue to me, i would like to build this feature.

@divyanshu-dj
Copy link

@jayantbh I was researching the webhook implementation and just need a quick clarification: what specific fields/parameters should we expect from third-party systems for each incident? (I'm thinking incident ID, severity, description, detected timestamp).

@adnanhashmi09
Copy link
Contributor

#562 (comment)

Please check out the guidelines in this issue. These two issues are very similar in implementation and would largely use the similar services and APIs that one of these issue end up implementing. So before we begin the implementation it is better to have the approach well discussed and documented here. This is a rather challenging and time taking task.

As for the what request body we want from the user, you can read through the incident service to get a better understanding of our system.

@jayantbh
Copy link
Contributor Author

jayantbh commented Oct 8, 2024

@xyfer17 @divyanshu-dj ^ the linked comment will offer much needed context.

@Kamlesh72
Copy link
Contributor

@jayantbh @adnanhashmi09
Why use webhooks and not through rest api provided by incident management solutions?

@adamlyka
Copy link

adamlyka commented Feb 7, 2025

A simple set of CRUD api endpoints for incidents would be highly beneficial for creating integrations into middleware. Linear B offers something similar: https://docs.linearb.io/api-incidents/
Many similarly for tracking deployments.

@adnanhashmi09
Copy link
Contributor

We plan to introduce webhooks first, allowing users to integrate their incident providers without requiring us to support each integration individually. Users can send data to us via the webhook—the same data we would otherwise fetch from the incident providers' REST APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced These are not really meant for beginners or brand new contributors, but feel free to give it a shot! enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants