Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necrotic Wake, before fighting the next to last boss #200

Open
bcarpio opened this issue Dec 7, 2020 · 10 comments
Open

Necrotic Wake, before fighting the next to last boss #200

bcarpio opened this issue Dec 7, 2020 · 10 comments

Comments

@bcarpio
Copy link

bcarpio commented Dec 7, 2020

I just ran The Necrotic Wake, before fighting the next to last boss, you're taken up into the flying Necropolis.
As soon as I landed inside I started receiving a flood of error messages, unfortunately I wasn't able to copy it at the time because I couldn't continue to do the instance until WoW asked if I wanted to Disable all my addons because of the error.

I tried to locate a log file but was unable to find one. Sorry that I can't provide more details. But I do know that it was specifically referring to Carbonite and NXMap. It was basically indicating that a variable or index was undefined.

Copied from the https://www.curseforge.com/ page.

@Thrumbar
Copy link
Contributor

Thrumbar commented Dec 8, 2020

This sounds like a reported error on WoWInterface forums.. Copied below.. This error does not use the latest from Git but I do not think it matters as the error line in 12271 instead of the one listed in the report and could be the zone not in database.

Everytime we reach the final two bosses above the main floor, this error constantly gets thrown

34946x Carbonite\NxMapData.lua:12270: attempt to index field '?' (a nil value)
[string "@carbonite\NxMapData.lua"]:12270: in function GetZoneInfo' [string "@Carbonite\NxMap.lua"]:9855: in function IsInstanceMap'
[string "@carbonite\NxMap.lua"]:5328: in function SwitchRealMap' [string "@Carbonite\NxMap.lua"]:4512: in function Update'
[string "@carbonite\NxMap.lua"]:4021: in function <Carbonite\NxMap.lua:3905>

Locals:
self =

{
Menu_OnTrackPlyr = defined @carbonite\NxMap.lua:2960
GetInstanceID = defined @carbonite\NxMap.lua:9524
ZoneOverlays =
{
}
HideExtraFrames = defined @Carbonite.Info\NxInfo.lua:1290
GetZoneAchievement = defined @carbonite\NxMap.lua:11144
MinimapOwnInit = defined @carbonite\NxMap.lua:1979
RestoreBlizzBountyMap = defined @carbonite\NxMap.lua:3332
MapLevels =
{
}
MinimapSetScale = defined @carbonite\NxMap.lua:2602
OnButToggleGuide = defined @carbonite\NxMap.lua:1669
GetWinName = defined @carbonite\NxMap.lua:1254
SetToCurrentZone = defined @carbonite\NxMap.lua:9606
GetIconStatic = defined @carbonite\NxMap.lua:8609
UpdateToolBar = defined @carbonite\NxMap.lua:1291
Menu_OnBackgndAlphaFade = defined @carbonite\NxMap.lua:2865
BlizzToggleWorldMap = defined @carbonite\NxMap.lua:3359
Menu_OnMapDebugFullCoords = defined @carbonite\NxMap.lua:2911
ClipFrameByMapType = defined @carbonite\NxMap.lua:7234
ZandalarMapBlks =
{
}
ResetIcons = defined @carbonite\NxMap.lua:8336
Minimap_OnEvent = defined @carbonite\NxMap.lua:2068
UnpackObjective = defined @carbonite\NxMap.lua:11392
GetWorldContinentInfo = defined @carbonite\NxMap.lua:9910
ReverseTargets = defined @carbonite\NxMap.lua:10230
GetWorldZoneScale = defined @carbonite\NxMap.lua:9977
GMenu_OnPasteLink = defined @carbonite\NxMap.lua:3089
ContCnt = 13
CreateToolBar = defined @carbonite\NxMap.lua:1261
PlyrNamesTipStr = ""
GetPlayerMapPosition = defined @carbonite\NxMap.lua:11700
RestoreWorldMap = defined @carbonite\NxMap.lua:11430
DetachWorldMap = defined @carbonite\NxMap.lua:1504
ClearTarget = defined @carbonite\NxMap.lua:10192
BGMenu_OnHelp = defined @carbonite\NxMap.lua:3125
UnregisterAllEvents = defined @ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
VerifySettings = defined @carbonite\NxMap.lua:313
HideMiniFrames = defined @carbonite\NxMap.lua:7121
HideExtraZoneTiles = defined @carbonite\NxMap.lua:6460
Menu_OnDetailAlpha = defined @carbonite\NxMap.lua:2861
IsInstanceMap = defined @carbonite\NxMap.lua:9851
EkMapBlks =
{
}
CheckWorldHotspotsType = defined @carbonite\NxMap.lua:6257
BuildPlyrLists = defined @carbonite\NxMap.lua:8748
SetMapByID = defined @carbonite\NxMap.lua:237
Menu_OnScaleRestore = defined @carbonite\NxMap.lua:2825
Menu_OnBackgndAlphaFull = defined @carbonite\NxMap.lua:2877
DraeneiXO = -3500
SetIconTypeAlpha = defined @carbonite\NxMap.lua:7977
MMMenuIFull =
{
}
CreateIconMenu = defined @carbonite\NxMap.lua:1301
WMDF = WMDF {
}
ScanContinents = defined @carbonite\NxMap.lua:5353
MinimapUpdateMask = defined @carbonite\NxMap.lua:2613
OLMapBlks =
{
}
Menu_OnPlyrFollow = defined @carbonite\NxMap.lua:2841
Menu_OnGetQuests = defined @carbonite\NxMap.lua:2951
__index =
{
}
I

@IrcDirk
Copy link
Collaborator

IrcDirk commented Dec 8, 2020

Shit... no time to debug it... Ill try to do the fix but u need to test it.

@bcarpio
Copy link
Author

bcarpio commented Dec 8, 2020

I can try and test it, let me know when you push the update.

@instant0
Copy link

instant0 commented Dec 12, 2020

Edit: Follow Mikepauers fix below instead to get it working properly.

If you edit "NxMapData.lua" and add the following around line 1655 (you'll see where it could go, but anywhere around this will be fine).

[1667] = {
	Scale = 1,
	X = -341.75,
	Y = 312,
	Name = L["The Necrotic Wake - Stichwerks"],
	BaseMap = 1667,
	Alpha = .85,
	MapLevel = 1,
},
[1668] = {
	Scale = 1,
	X = -341.75,
	Y = 312,
	Name = L["The Necrotic Wake - Zolramus"],
	BaseMap = 1668,
	Alpha = .85,
	MapLevel = 1,
},

This fixes the error messages, but it does not show the dungeon canvas map for these two encounters, as I couldn't figure out how.

@IrcDirk
Copy link
Collaborator

IrcDirk commented Dec 12, 2020

Im little busy right now. But ill make fix.

@instant0 this is just a workaround, but thanks.

@mikepauer
Copy link
Owner

As it's a dungeon they shouldn't be in NxMapData, but instead in Data\zones.lua

Something like:
[1666] = L["The Necrotic Wake"] .. "|50|60|3|5|1533|40.13|55.24|5",
[1667] = L["The Necrotic Wake - Stichwerks"] .. "|50|60|3|5|1533|40.13|55.24|0",
[1668] = L["The Necrotic Wake - Zolramus"] .. "|50|60|3|5|1533|40.13|55.24|0",

@IrcDirk
Copy link
Collaborator

IrcDirk commented Dec 12, 2020

@mikepauer it can be, there is bug in auto zone adding function that i did added.

@mikepauer
Copy link
Owner

I'd try and do fixes, but right now no computer.. been waiting 2 months now for CPU delivery so I can build and get back in... hopefully not much longer so your not doing it alone.

@instant0
Copy link

instant0 commented Dec 12, 2020

@mikepauer Thanks, adding those and removing my workaround fixed it and added the map information correctly.
Just tested it now.

@IrcDirk
Copy link
Collaborator

IrcDirk commented Dec 12, 2020

@instant0 yes this needs to work, i will add this to Carbonite. But i need to fix this automatic zone adding too ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants