Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: refine array view to optimize memory usage(#38736) #38808

Merged
merged 1 commit into from
Jan 7, 2025
Merged

enhance: refine array view to optimize memory usage(#38736) #38808

merged 1 commit into from
Jan 7, 2025
+212 −141

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Dec 27, 2024 •
edited
Loading

related: #38736

700m data, array_length=10
non-mmap_offsets_uint64: 2.0G
mmap_offsets_uint64: 1.1G
mmap_offsets_uint32: 880MB

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 30f7f6c to 48a53db Compare December 27, 2024 12:27
@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 48a53db to 22404ce Compare December 27, 2024 12:28
@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (ee9a279) to head (4d80704).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/common/Array.h 94.33% 3 Missing ⚠️
internal/core/src/mmap/Utils.h 40.00% 3 Missing ⚠️
internal/core/src/mmap/ChunkVector.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38808       +/-   ##
===========================================
+ Coverage   69.52%   81.14%   +11.61%     
===========================================
  Files         296     1388     +1092     
  Lines       26553   196528   +169975     
===========================================
+ Hits        18462   159480   +141018     
- Misses       8091    31454    +23363     
- Partials        0     5594     +5594
Components Coverage Δ
Client 79.53% <ø> (∅)
Core 69.55% <93.75%> (+0.02%) ⬆️
Go 83.10% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/Chunk.cpp 70.27% <100.00%> (-1.53%) ⬇️
internal/core/src/common/ChunkWriter.cpp 58.03% <100.00%> (+0.27%) ⬆️
internal/core/src/mmap/ChunkData.h 97.61% <100.00%> (+0.32%) ⬆️
internal/core/src/mmap/Column.h 91.20% <100.00%> (+0.36%) ⬆️
internal/core/src/segcore/SegmentSealedImpl.cpp 84.48% <100.00%> (ø)
internal/core/src/storage/MmapChunkManager.cpp 84.00% <ø> (ø)
internal/core/src/mmap/ChunkVector.h 83.87% <0.00%> (ø)
internal/core/src/common/Array.h 92.25% <94.33%> (-0.75%) ⬇️
internal/core/src/mmap/Utils.h 82.60% <40.00%> (-3.55%) ⬇️

... and 1092 files with indirect coverage changes

@MrPresent-Han
Copy link
Contributor Author

rerun ut

1 similar comment
@MrPresent-Han
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Dec 30, 2024
@sunby
Copy link
Contributor

sunby commented Dec 30, 2024

/lgtm

xiaofan-luan
xiaofan-luan reviewed Dec 30, 2024
View reviewed changes
internal/core/src/common/Array.h Outdated
@@ -438,19 +438,42 @@ class Array {
int size_ = 0;
std::vector<uint64_t> offsets_{};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. why not still keep offset ? Didn't see a strong reason to do so.
  2. why not change offset to unint32?

@MrPresent-Han
Copy link
Contributor Author

/hold

@sre-ci-robot sre-ci-robot added do-not-merge/hold size/L Denotes a PR that changes 100-499 lines. and removed lgtm size/M Denotes a PR that changes 30-99 lines. labels Dec 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. ci-passed labels Dec 31, 2024
@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from e9f48cb to e9a67eb Compare December 31, 2024 06:00
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from f5c49d7 to 0981575 Compare January 3, 2025 14:36
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 0981575 to 47f2ae8 Compare January 4, 2025 15:42
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 47f2ae8 to 0d98657 Compare January 5, 2025 02:15
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 5, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 5, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@MrPresent-Han
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 5, 2025
MrPresent-Han
MrPresent-Han commented Jan 6, 2025
View reviewed changes
internal/core/src/common/Array.h Show resolved Hide resolved
internal/core/src/common/ChunkWriter.cpp Show resolved Hide resolved
internal/core/src/common/ChunkWriter.cpp Show resolved Hide resolved
internal/core/src/mmap/Column.h Show resolved Hide resolved
internal/core/src/mmap/Column.h Show resolved Hide resolved
@mergify mergify bot removed the ci-passed label Jan 6, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 0d98657 to 4d80704 Compare January 6, 2025 11:48
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@xiaofan-luan
Copy link
Collaborator

/assign @wangting0128

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrPresent-Han, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 7, 2025
@MrPresent-Han
Copy link
Contributor Author

/unhold

@sre-ci-robot sre-ci-robot merged commit 3739446 into milvus-io:master Jan 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@sunby sunby

@wangting0128 wangting0128

@xiaofan-luan xiaofan-luan

Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrPresent-Han @sunby @xiaofan-luan @sre-ci-robot @wangting0128