Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: FileSource may return empty config map when io operation fails #38923

Open
1 task done
congqixia opened this issue Jan 2, 2025 · 0 comments
Open
1 task done

[Bug]: FileSource may return empty config map when io operation fails #38923

congqixia opened this issue Jan 2, 2025 · 0 comments
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master & 2.5.1 & 2.4.19
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

FileSource may return empty config map when io operation fails

Expected Behavior

An error shall be return when refreshing config map

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 2, 2025
@congqixia congqixia self-assigned this Jan 2, 2025
congqixia added a commit to congqixia/milvus that referenced this issue Jan 2, 2025
@congqixia
fix: Return io error other than NotExist refreshing config
491e027 
Related to milvus-io#38923

This PR:

- Check whether `os.Stat` config file error is io.ErrNotExist
- Panic if refresher get error

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Jan 2, 2025
Open
congqixia added a commit to congqixia/milvus that referenced this issue Jan 7, 2025
@congqixia
fix: Return io error other than NotExist refreshing config
56c1472 
Related to milvus-io#38923

This PR:

- Check whether `os.Stat` config file error is io.ErrNotExist
- Panic if refresher get error

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia