Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Add log for case which target not update as expected #38944

Merged
merged 1 commit into from
Jan 7, 2025
Merged

enhance: Add log for case which target not update as expected #38944

merged 1 commit into from
Jan 7, 2025

Conversation

weiliu1031
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 2, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 2, 2025
@weiliu1031 weiliu1031 force-pushed the add_log_for_target_ob branch 2 times, most recently from d7a6dc1 to 97d1685 Compare January 2, 2025 09:13
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 2, 2025
This was referenced Jan 2, 2025
Merged
Merged
czs007 pushed a commit that referenced this pull request Jan 2, 2025
@bigsheeper @weiliu1031
enhance: [10ckp] Add log for case which target not update as expected (…
b6c18f7 
…#38952)

pr: #38944

Signed-off-by: bigsheeper <[email protected]>
Co-authored-by: Wei Liu <[email protected]>
czs007 pushed a commit that referenced this pull request Jan 2, 2025
@bigsheeper @weiliu1031
fix: [10kcp] Querycoord will trigger unexpected balance task after re…
7934c21 
…start (#38951)

pr: #38944

Signed-off-by: bigsheeper <[email protected]>
Co-authored-by: wei liu <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (ee9a279) to head (9e1e9eb).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38944       +/-   ##
===========================================
+ Coverage   69.52%   81.13%   +11.60%     
===========================================
  Files         296     1388     +1092     
  Lines       26553   196485   +169932     
===========================================
+ Hits        18462   159418   +140956     
- Misses       8091    31467    +23376     
- Partials        0     5600     +5600
Components Coverage Δ
Client 79.53% <ø> (∅)
Core 69.52% <ø> (ø)
Go 83.08% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/utils/util.go 85.54% <100.00%> (ø)

... and 1091 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the add_log_for_target_ob branch from 97d1685 to 0521a59 Compare January 6, 2025 03:36
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the add_log_for_target_ob branch from 0521a59 to 9e1e9eb Compare January 6, 2025 11:11
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 7, 2025
@tedxu
Copy link
Contributor

tedxu commented Jan 7, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 47e7ea2 into milvus-io:master Jan 7, 2025
20 checks passed
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Jan 7, 2025
@weiliu1031
enhance: Add log for case which target not update as expected (milvus…
32088a8 
…-io#38944)

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 mentioned this pull request Jan 7, 2025
Merged
sre-ci-robot pushed a commit that referenced this pull request Jan 8, 2025
@weiliu1031
enhance: Add log for case which target not update as expected (#38944) (
35cef05 
#39046)

pr: #38944

Signed-off-by: Wei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@jiaoew1991 jiaoew1991 Awaiting requested review from jiaoew1991

Assignees

@tedxu tedxu

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliu1031 @tedxu @sre-ci-robot