-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: move streaming coord from datacoord to rootcoord #39009
enhance: move streaming coord from datacoord to rootcoord #39009
Conversation
@chyezh go-sdk check failed, comment |
@chyezh E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #39009 +/- ##
===========================================
+ Coverage 69.45% 81.06% +11.61%
===========================================
Files 294 1384 +1090
Lines 26419 195536 +169117
===========================================
+ Hits 18349 158518 +140169
- Misses 8070 31444 +23374
- Partials 0 5574 +5574
|
Signed-off-by: chyezh <[email protected]>
Signed-off-by: chyezh <[email protected]>
4b10eb3
to
9ff7e5b
Compare
@chyezh E2e jenkins job failed, comment |
/run-cpu-e2e |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #38399
pr: #39007
We want to support broadcast operation for both streaming and msgstream.
But msgstream can be only sent message from rootcoord and proxy.
So this pr move the streamingcoord to rootcoord to make easier implementation.