-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [2.5] Optimize retrieve performance utilizing bitset SIMD methods #39041
Conversation
…lvus-io#39004) Related to milvus-io#39003 Signed-off-by: Congqi Xia <[email protected]>
Related to milvus-io#39003 Copying bitset value bit by bit is slow and CPU heavy, this PR utilizes bitset operator "|=" to accelerate this procedure Signed-off-by: Congqi Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #39041 +/- ##
==========================================
- Coverage 81.06% 81.05% -0.02%
==========================================
Files 1383 1383
Lines 195559 195569 +10
==========================================
- Hits 158531 158512 -19
- Misses 31455 31481 +26
- Partials 5573 5576 +3
|
Cherry pick from master
pr: #39004 #39037
Related to #39003