Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Optimize retrieve performance utilizing bitset SIMD methods #39041

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #39004 #39037
Related to #39003

Related to milvus-io#39003

Copying bitset value bit by bit is slow and CPU heavy, this PR utilizes
bitset operator "|=" to accelerate this procedure

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 7, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 7, 2025
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liliu-z
Copy link
Member

liliu-z commented Jan 7, 2025

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (b457c2f) to head (fec1b3b).
Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 9 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39041      +/-   ##
==========================================
- Coverage   81.06%   81.05%   -0.02%     
==========================================
  Files        1383     1383              
  Lines      195559   195569      +10     
==========================================
- Hits       158531   158512      -19     
- Misses      31455    31481      +26     
- Partials     5573     5576       +3     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.43% <18.18%> (-0.02%) ⬇️
Go 83.03% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/exec/expression/TermExpr.cpp 84.75% <100.00%> (+0.08%) ⬆️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.84% <0.00%> (-0.09%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.cpp 84.10% <0.00%> (-0.33%) ⬇️

... and 25 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 7, 2025
@sre-ci-robot sre-ci-robot merged commit 0b62c1e into milvus-io:2.5 Jan 7, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants