Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add broadcast for streaming service #39047

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 7, 2025

issue: #38399
pr: #39020

  • Add new rpc for transfer broadcast to streaming coord
  • Add broadcast service at streaming coord to make broadcast message sent automicly

also cherry pick the pr #38400

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 7, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 7, 2025
Copy link
Contributor

mergify bot commented Jan 7, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

chyezh added 2 commits January 7, 2025 19:15
- Add new rpc for transfer broadcast to streaming coord
- Add broadcast service at streaming coord to make broadcast message
  sent

Signed-off-by: chyezh <[email protected]>
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 73.11475% with 164 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (6f1febe) to head (1a4b760).
Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
.../streamingcoord/client/broadcast/broadcast_impl.go 15.62% 27 Missing ⚠️
...eamingcoord/server/broadcaster/broadcaster_impl.go 83.08% 18 Missing and 5 partials ⚠️
pkg/streaming/util/message/builder.go 58.33% 11 Missing and 9 partials ⚠️
internal/distributed/streamingnode/service.go 60.00% 12 Missing and 6 partials ⚠️
...nternal/streamingcoord/server/service/broadcast.go 22.22% 14 Missing ⚠️
...ingnode/server/flusher/flusherimpl/flusher_impl.go 75.00% 8 Missing and 4 partials ⚠️
pkg/streaming/util/message/message_impl.go 79.48% 4 Missing and 4 partials ⚠️
internal/streamingcoord/server/server.go 65.00% 5 Missing and 2 partials ⚠️
internal/metastore/kv/streamingcoord/kv_catalog.go 78.57% 4 Missing and 2 partials ⚠️
...ode/server/flusher/flusherimpl/channel_lifetime.go 45.45% 4 Missing and 2 partials ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39047       +/-   ##
===========================================
+ Coverage   69.43%   81.06%   +11.63%     
===========================================
  Files         294     1388     +1094     
  Lines       26429   196073   +169644     
===========================================
+ Hits        18351   158951   +140600     
- Misses       8078    31530    +23452     
- Partials        0     5592     +5592     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.43% <ø> (ø)
Go 83.04% <73.11%> (∅)
Files with missing lines Coverage Δ
internal/distributed/streaming/streaming.go 100.00% <ø> (ø)
internal/distributed/streaming/wal.go 64.22% <100.00%> (ø)
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/streamingcoord/client/client.go 96.82% <100.00%> (ø)
...reamingcoord/server/broadcaster/append_operator.go 100.00% <100.00%> (ø)
internal/streamingcoord/server/broadcaster/task.go 100.00% <100.00%> (ø)
internal/streamingcoord/server/builder.go 100.00% <100.00%> (ø)
...nternal/streamingcoord/server/resource/resource.go 95.91% <100.00%> (ø)
internal/streamingnode/server/builder.go 100.00% <100.00%> (ø)
internal/streamingnode/server/resource/resource.go 88.40% <100.00%> (ø)
... and 27 more

... and 1057 files with indirect coverage changes

@chyezh chyezh force-pushed the enhance_add_broadcast_for_msg_system_2_5 branch from 76fe3a0 to 1a4b760 Compare January 7, 2025 11:23
Copy link
Contributor

mergify bot commented Jan 7, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 7, 2025
@chyezh
Copy link
Contributor Author

chyezh commented Jan 8, 2025

rerun go-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants