Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undesired multiple login attempts on failure [Feature request] #13

Open
neworld opened this issue Oct 2, 2018 · 2 comments
Open

Undesired multiple login attempts on failure [Feature request] #13

neworld opened this issue Oct 2, 2018 · 2 comments

Comments

@neworld
Copy link
Contributor

neworld commented Oct 2, 2018

I am using OAuth service, which supports only form data for password grant type. So, additional tries are wasting resources. OAuth service is throttling multiple requests and sometimes even block IP. A user is able to get a block 3 times easier.

I understand why this behavior is implemented. However, would be cool to configure them. I could implement it by myself. But I am needed agreement on API.

I would suggest adding:

public OAuth2Client.Builder failback(Failback failback) { .... }

enum Failback {
  FULL, BASIC_AUTH, AUTHORIZATION, NOTHING
}

Failback could be called RequestType as well.

Of course, the default behavior has to remain.

@corcoran
Copy link
Member

I like this idea!

Failback would be good I think. Having failback default to the old (FULL) behavior and allow for an optional enum param would work.

The change could be entirely in AuthState.nextState()

@avishaigurt-oviva
Copy link
Contributor

avishaigurt-oviva commented Jul 4, 2019

I submitted a pull request which expose the Authenticator to the builder so you can rather set it to the default behaviour or implement one yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants