-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recommendations to compliance findings #2567
Comments
#2569 |
The issue here is not only the recommendations from the database (great to see those being improved :D). The example from the image about the firewall, actually has already a recommendation, it is just not available in the report |
To make it more clear what we are talking about I've included the updated findings database for the firewall finding below. If we were to add this column, that would raise the question 'What ports were identified to be open', so personally I'd expect those to be available somewhere too. @noamblitz any idea how feasible it is to add a 'proof'-like column inthere as well? I can expect the report will become either messy, or it is technically difficult to currently add this data.
|
You can already add "proof": "..." (some finding types already have it)! It is not hard to add that to the report! |
In general: the vulnerabilities in the report take the approach of unfolding a vulnerability for more details. I can imagine that could be a solution here to, to incorporate the extra available data. In the case of the open port; I do not think these kind of findings should exist in this chapter, since it is also clear from the |
Is your feature request related to a problem? Please describe.
Items such as "The firewall may be configured in a riskful manner." are too vague.
Describe the solution you'd like
The
kat_finding_types.json
already includes recommendations. These could be included in the findings. Alternatively, the appendix could contain detailed information in how a conclusion was drawn.The text was updated successfully, but these errors were encountered: