Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations in Aggregate Report are too general #3874

Open
4 tasks
madelondohmen opened this issue Nov 21, 2024 · 4 comments
Open
4 tasks

Recommendations in Aggregate Report are too general #3874

madelondohmen opened this issue Nov 21, 2024 · 4 comments
Assignees
Labels
bug Something isn't working design UI/UX

Comments

@madelondohmen
Copy link
Contributor

Follow up of ticket #3837

Describe the bug
Some issues have been found in the reports that are a bit confusing.

  • Aggregate report, Chapter 1 - Recommendations (screenshot 1)
    • The recommendations are too general ("this port")
  • Aggregate report, Vulnerabilities (screenshot 2)
    • Too general ("a database port")

To Reproduce
Steps to reproduce the behavior:

  1. Create an Aggregate Report
  2. Select a lot of objects
  3. Select all report types

Screenshots
Screenshot 1:
Image

Screenshot 2:
Image

OpenKAT version
main

@madelondohmen madelondohmen added bug Something isn't working discussion labels Nov 21, 2024
@madelondohmen madelondohmen moved this to Backlog / To do in KAT Nov 21, 2024
@madelondohmen madelondohmen self-assigned this Nov 21, 2024
@RomijnHumanoids RomijnHumanoids self-assigned this Nov 26, 2024
@RomijnHumanoids RomijnHumanoids moved this from To be discussed to Backlog / To do in KAT Nov 26, 2024
@madelondohmen
Copy link
Contributor Author

Outcome of discussion meeting 26-11-2024:

Idea 1: Make the recommendations more general
Idea 2: Make the recommendations clickable
Idea 3: Change the section: do we want to show issues or recommendations?

We have to reconsider the design of the top part of the Aggregate Report.

@RomijnHumanoids
Copy link

Let's discuss this with stakeholders in the next UX session December 4.

  • What should be in the management summary of a report? How can we improve our 'recommendations' section.
    • How to aggregate and how much detail per recommendation/finding.

@RomijnHumanoids
Copy link

RomijnHumanoids commented Dec 5, 2024

This is discussed in stakeholder session on December 4. A small design will follow (#3938) with the proposed improvements: show risks and sort recommendations based on this (risk levels are connected to finding types), and link to the findings further in report while keeping the recommendations generic and not mention specific objects/findings.

I think we missed forming (or making notes of) a solution for the problem in the second screenshot in this ticket when discussing it within the openKAT team on 26/11/2024.

@madelondohmen
Copy link
Contributor Author

Outcome of discussion meet 10-12-2024:

The second screenshot might already be fixed. We have to go through the report to check if this part is fixed.
@RomijnHumanoids @madelondohmen and @stephanie0x00 will check this.

@madelondohmen madelondohmen moved this from To be discussed to Backlog / To do in KAT Dec 10, 2024
@RomijnHumanoids RomijnHumanoids moved this from Backlog / To do to Review in KAT Dec 19, 2024
@Rieven Rieven moved this from Review to In Progress in KAT Jan 7, 2025
@Rieven Rieven moved this from In Progress to Backlog / To do in KAT Jan 7, 2025
@madelondohmen madelondohmen moved this from Backlog / To do to In Progress in KAT Feb 6, 2025
@madelondohmen madelondohmen moved this from In Progress to To be discussed in KAT Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design UI/UX
Projects
Status: To be discussed
Development

No branches or pull requests

3 participants