Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): MkInstanceTickerの情報がリアクティブでない問題を修正 #15123

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 13, 2024

What

プラグインでinstance情報周りを書き換えても、その書換がMkInstanceTickerまで伝播していなかったのを修正

Why

Fix #15122

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.98%. Comparing base (85be61d) to head (3b3311b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15123       +/-   ##
============================================
- Coverage    40.47%   19.98%   -20.49%     
============================================
  Files         1568      731      -837     
  Lines       199140   104490    -94650     
  Branches      3955     1200     -2755     
============================================
- Hits         80593    20884    -59709     
+ Misses      117942    83052    -34890     
+ Partials       605      554       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@tai-cha
Copy link
Contributor

tai-cha commented Jan 17, 2025

/preview

@mi-gh-maintainer mi-gh-maintainer bot merged commit f01fc5a into misskey-dev:develop Jan 17, 2025
9 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-15122 branch January 18, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

Can't change note.user.instance.name with register_note_view_interruptor
2 participants