-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirect to domain name #359
Comments
Hmmm. so I dont really have a good intuition on which approach would be better for this. Both approaches seem relatively easy. We have the two different domains for research and teaching uses, right? Is this important? |
@keving17 Yep, I think both steps would be good - add redirection on the server so that if the domian isn't I don't think having separately domains was intentional, it's just historical from before we had our own domain, and people still using older links. |
Hmmm. So I'm working on getting rid of the domain in the queries right now and I can't figure out how to work around string manipulation. From what I can see, the correct way to do the psql query for partial matches is
but I can't seem to add the Also, how exactly does the redirect work? I don't see anything that seems relevant in index.js |
@kevinrobinson any ideas here? |
@keving17 For querying, this may be helpful to check out: https://stackoverflow.com/questions/19471756/how-to-make-a-like-search-in-postgresql-and-node-js. For the redirect, grep for |
Because the domain is used in querying for data, you can access different data based on the domain that's used for the learner experience or the researcher experience.
We should probably start redirecting everything to https://teachermoments.teachingsystemslab.org/ to make this simpler going forward. We could also update the query for researcher data to not care about the specific domain (just the path part of the URL).
FWIW @keving17 I ran into this just now, trying to use https://teachermoments.teachingsystemslab.org/ for data entered at the herokuapp domain. :)
The text was updated successfully, but these errors were encountered: