Inner border radius.

[mimoguz]

Hi.

First, please let me say that you're doing a tremendous job. Kudos, and thank you!

Now, my suggestion: define an inner border radius config. Right now for many components' borders are drawn using multiple backgrounds. The problem is, both outer and inner backgrounds have the same radius. This causes noticeable artifacts with rounded borders, like this (at %400):

As you can see, borders are much thicker at corners.

I think this can safely be fixed by defining an inner corner radius like this (pardon my Sass):

// _config.scss
$inner-border-radius: math.max($border-radius - $border-width, 0) !default;

// _checkbox.scss
-fx-background-radius: cfg.$border-radius, cfg.$inner-border-radius;

I have a fork with fixes if you want to take a look: https://github.com/mimoguz/atlantafx

[mkpaz]

Thanks! This a really good suggestion. I noticed that border corners don't look good enough, but not tackled the problem yet. Right now I'm a little busy with another JavaFX project. Feel free to commit if you're willing to spare some time for this, I'll gladly accept the PR.

[mimoguz]

Sure 👍

[mimoguz]

Created a pull request.

While testing my changes, I saw another issue with split spinners:

Is that -1 background inset intentional?

[mkpaz]

Nice catch! Fixed it. Probably it was, but became a bug after refactoring.