-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with other JavaFX libraries #41
Comments
Third-party libs support is in the backlog. Your suggestion sounds reasonable, though I'd not include this snippet to the themes, but having something like |
@crschnick |
I just define all the needed style class color definitions from modena.css with the appropriate AtlantaFX color definitions for every single node with |
@crschnick could you paste that rule here so others can save tons of time? |
It is the one in the original post |
Ah ok ... I thought there would be more. E.g. -fx-accent, -fx-selection-bar-text etc .... |
I originally set colors until it looked fine. There might be some I missed but these did not influence the look of the preferences in my case. To be fair, I switched to using some custom renderers using AtlantaFX controls instead of formsfx controls, so I do not have full coverage of all controls. |
Hey, controls is not completely dead. |
One issue that I have run into is that several other javafx libraries expect modena color scheme definitions to be present. For example, https://github.com/dlsc-software-consulting-gmbh/PreferencesFX will print out all kinds of errors when used with AtlantaFX.
My current solution is to define the manually like this:
Maybe they can be defined automatically by AtlantaFX. It doesn't have to be a perfect match, just some default colors that come close to the modena theme.
The text was updated successfully, but these errors were encountered: