Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect height of list cells #80

Open
dlemmermann opened this issue Nov 21, 2023 · 2 comments
Open

Incorrect height of list cells #80

dlemmermann opened this issue Nov 21, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@dlemmermann
Copy link

The screenshot below shows how PDFViewFX is trying to render the page thumbnails in a ListView on the left-hand side. For some reason the cell height remains fixed with a low value instead of adjusting to the height of the thumbnails when using AtlantaFX. PDFViewFX does not explicitly set a height for the cells.

Bildschirmfoto 2023-11-21 um 10 53 42
@dlemmermann
Copy link
Author

dlemmermann commented Nov 21, 2023

It is possible to work around this by explicitly adding -fx-cell-size: -1; to the pdf-view.css file, but I am worried that AtlantaFX changed the default behaviour, hence breaking a lot of apps that are looking into using it. This in turn will lead to a lower adoption rate.

@mkpaz
Copy link
Owner

mkpaz commented Aug 8, 2024

Yes, that's correct. Table cells have a fixed height by default. To set any custom content other than string, the cell size must be reset. This should be specified explicitly in the doc.

@mkpaz mkpaz added the documentation Improvements or additions to documentation label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants