Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes:
script_function
intoscript_module
. This is fixed now (in a somewhat hacky way)Open questions.
$forward
method. Maybe we want to do this for all methods.$forward
method (that distinguishes between the internal train and eval forward method) in the underlying script module instead of thenn_Module
?TODOs:
script_module
is changed. This should probably be fixed.$forward
method is not defined. This is because the underlying module class is not saved when saving a trace jitted module, so when loading it again, the unpatched methods are used.