From fa88270b07e447bf4d3d65b081c8f728bc4ba1f7 Mon Sep 17 00:00:00 2001 From: Michael McLoughlin Date: Sun, 3 May 2020 22:38:00 -0700 Subject: [PATCH] script: pin tool dependencies An update to gofumpt caused the lint job to start failing: https://github.com/mmcloughlin/avo/runs/638734114?check_suite_focus=true#step:7:688 The underlying issue is that the "join parameters" rule added to gofumpt disagrees with output from go/types. It's possible to fix, but I don't think it's important enough to deal with right now. Instead I'll pin the gofumpt dependency to a version before that rule was added. Pinning tool dependencies is a good idea anyway. --- script/bootstrap | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/script/bootstrap b/script/bootstrap index 53313381..d9d69685 100755 --- a/script/bootstrap +++ b/script/bootstrap @@ -10,17 +10,17 @@ go install ./internal/cmd/asmdecl golangci_lint_version='v1.23.6' curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $GOPATH/bin ${golangci_lint_version} -# Turn off modules for tools install. -export GO111MODULE=off +# Use gobin for tools install. +GO111MODULE=off go get -u github.com/myitcv/gobin # embedmd required for documentation generation -go get -u github.com/campoy/embedmd +gobin github.com/campoy/embedmd@v1.0.0 # covertool for merging coverage reports -go get -u github.com/dlespiau/covertool +gobin github.com/dlespiau/covertool@v0.0.0-20180314162135-b0c4c6d0583a # asmfmt for enforcing assembly style -go get -u github.com/klauspost/asmfmt/cmd/asmfmt +gobin github.com/klauspost/asmfmt/cmd/asmfmt@v1.2.1 # gofumports for stricter formatting -go get -u mvdan.cc/gofumpt/gofumports +gobin mvdan.cc/gofumpt/gofumports@v0.0.0-20200412215918-a91da47f375c