Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: windows #25

Open
mmcloughlin opened this issue Aug 26, 2023 · 0 comments
Open

ci: windows #25

mmcloughlin opened this issue Aug 26, 2023 · 0 comments

Comments

@mmcloughlin
Copy link
Owner

Fix tests on Windows.

There are some annoyances possibly related to line-endings, for example:

--- FAIL: TestFormatGolden (0.02s)
    --- FAIL: TestFormatGolden/poly1305 (0.00s)
Error:         golden_test.go:[7](https://github.com/mmcloughlin/mathfmt/actions/runs/5986804869/job/16240334229?pr=24#step:5:8)2: line number mismatch: got 30[8](https://github.com/mmcloughlin/mathfmt/actions/runs/5986804869/job/16240334229?pr=24#step:5:9) expect 307
    --- FAIL: TestFormatGolden/stats (0.00s)
Error:         golden_test.go:72: line 5:
            	got    = "//\t\t∑ xᵢ / N"
            	expect = "//\t∑ xᵢ / N"
Error:         golden_test.go:72: line 1[9](https://github.com/mmcloughlin/mathfmt/actions/runs/5986804869/job/16240334229?pr=24#step:5:10):
            	got    = "//\t\tσ² = ∑ (xᵢ - μ)² / N"
            	expect = "//\tσ² = ∑ (xᵢ - μ)² / N"
FAIL
exit status 1
FAIL	github.com/mmcloughlin/mathfmt	0.061s
Error: Process completed with exit code 1.

https://github.com/mmcloughlin/mathfmt/actions/runs/5986804869/job/16240334229?pr=24#step:5:7
mmcloughlin added a commit that referenced this issue Aug 26, 2023
@mmcloughlin
ci: disable windows
a7968f3 
Updates #25
mmcloughlin added a commit that referenced this issue Aug 26, 2023
@mmcloughlin
ci: bump to go 1.21 (#24)
9de306b 
Bump CI Go version to 1.21.x.

Update Golden tests to account for new documentation comment conventions.

Disable Windows CI tests due to undiagnosed problems with Golden tests.

Upgrade and reconfigure linter, and fix associated errors.

Updates #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmcloughlin