Typescripts/Javascript set hint not correctly in overriding props

[hiep294]

I design a models which can be extend like this:

const ProductList = types.model({
  items: types.map(types.model({
    price: types.optional(types.string, '')
  }))
})

const ProductListExtend = types.compose(
  ProductList,
  types.model({
    items: types.map(types.model({
      price: types.optional(types.number, 1)
    }))
  })
)

const List = ProductListExtend.create()
List.items.forEach(item => {
  // item is showing that it contain a string price, but a number is expected
})

In design above, items of ProductListExtend will be a map list of item which has price is a number. however, item is showing a hint that containing a price is a string.
My question is: Is there any way to show a hint correctly in javacriipt or typescript

[mweststrate]

I strongly recommend against redefining the type of an existing property, it is gonna be very confusing for future you :)

…

On Sat, Feb 22, 2020 at 3:10 PM hiep294 ***@***.***> wrote: I design a models which can be extend like this: const ProductList = types.model({ items: types.map(types.model({ price: types.optional(types.string, '') })) }) const ProductListExtend = types.compose( ProductList, types.model({ items: types.map(types.model({ price: types.optional(types.number, 1) })) }) ) const List = ProductListExtend.create() List.items.forEach(item => { // item is showing that it contain a string price, but a number is expected }) In design above, items of ProductListExtend will be a map list of item which has price is a *number*. however, item is showing a hint that containing a price is a *string*. My question is: Is there any way to show a hint correctly in javacriipt or typescript — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1473?email_source=notifications&email_token=AAN4NBED2ML4AGAZ6RISTVDREE57ZA5CNFSM4KZSGKU2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPPRT7Q>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBGXXB7KM2TDOFAM6E3REE57ZANCNFSM4KZSGKUQ> .

[hiep294]

I have many lists like types.model({items: types.map(A)}) with the same actions. I put these actions into GeneralList, also need to define 'items' prop in GeneralList, because these actions will apply the a specific result to items. in overview:

const GeneralList = types.model({
  items: types.map(GeneralModel)
}).actions(...common actions required 'items' prop)

const ListOfA = types.compose(
  GeneralList, 
  types.model({
    items: types.map(A)
}))

That's why I would like to redefine the type

[coolsoftwaretyler]

Hey @hiep294 - I know it's been a while since anyone got back to you here, but I think @mweststrate has a good point that re-defining the properties is an anti-pattern here.

What you might consider doing instead is defining some utility functions that don't know anything about MST at all, and using them in the actions block for better code reuse.

Is this still a relevant problem for you? Do any of these suggestions help out? Let me know and we can try to resolve it. Otherwise, I'll close this issue out if I don't hear back in two weeks or so.

[k-g-a]

@coolsoftwaretyler , just wanted to mention that this is the same as 1403.

@hiep294 , if this is still relevant, check out the proposed workaround from the above issue.

[coolsoftwaretyler]

Thanks @k-g-a! Good call. I'm going to close this issue out in favor of the workarounds in #1403 + perhaps some day we'll add some kind of official support to if (PRs welcome from the interested).

Thanks y'all!