Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle sidebar #3169

Open
3 tasks done
Markrealhd opened this issue Jan 19, 2025 · 3 comments
Open
3 tasks done

Toggle sidebar #3169

Markrealhd opened this issue Jan 19, 2025 · 3 comments
Labels
app Relates to Modrinth App bug Something isn't working

Comments

@Markrealhd
Copy link

Please confirm the following.

  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date

What version of the Modrinth App are you using?

0.9.2

What operating systems are you seeing the problem on?

Windows

Describe the bug

It is not possible to toggle the sidebar in the 'Discover content' tab.

Steps to reproduce

  1. Go to 'Settings'
  2. Enable 'Toggle sidebar'
  3. Go to 'Discover content'
  4. Try to toggle the sidebar

Expected behavior

I expect to see the arrow button to toggle the sidebar.

Additional context

It is annoying to browse mods with the sidebar open.
In all other tabs you can hide the sidebar; it is not consistent.
Advertisements to support the developers could also be placed between the mods when browsing.

@Markrealhd Markrealhd added app Relates to Modrinth App bug Something isn't working labels Jan 19, 2025
@Marcelo-maga
Copy link

I don’t think ads in the navigation are a good idea, but why is there this inconsistency between pages?

@Marcelo-maga
Copy link

Image

I found a function in the source code that forces the sidebar to stay active on these two pages, so I think there’s a valid reason why it can’t be hidden, just need to find out why and if the fix is ​​valid.

@Markrealhd
Copy link
Author

I think it's possible that the sidebar is forced because advertising is shown there, which is why I thought you should be able to deactivate it and if advertising is necessary it should be placed better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Relates to Modrinth App bug Something isn't working
Development

No branches or pull requests

2 participants