From ad8534b0c3f9e0e3f58d6ce976d99adbefaf2d43 Mon Sep 17 00:00:00 2001
From: Rivka Ungar <rivkaun@monday.com>
Date: Wed, 8 Jan 2025 20:30:32 +0200
Subject: [PATCH 1/2] fix(Dropdown): aria labels not passed to dropdown menu

---
 packages/core/src/components/Dropdown/components/menu/menu.jsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/core/src/components/Dropdown/components/menu/menu.jsx b/packages/core/src/components/Dropdown/components/menu/menu.jsx
index e14f63ab78..35af0560f7 100644
--- a/packages/core/src/components/Dropdown/components/menu/menu.jsx
+++ b/packages/core/src/components/Dropdown/components/menu/menu.jsx
@@ -10,6 +10,7 @@ const Menu = ({ children, Renderer, selectProps, dropdownMenuWrapperClassName, i
     ...props,
     innerProps: {
       ...props.innerProps,
+      onScroll: props.onScroll,
       id,
       role: "listbox",
       "aria-label": ariaLabel
@@ -30,7 +31,7 @@ const Menu = ({ children, Renderer, selectProps, dropdownMenuWrapperClassName, i
   return (
     <components.Menu
       {...props}
-      innerProps={{ ...props.innerProps, onScroll: props.onScroll }}
+      innerProps={{ ...rendererProps.innerProps }}
       className={cx(
         styles.dropdownMenuWrapper,
         {

From b7f0e2212f8524dcf5a5bde5d974189432d7d77e Mon Sep 17 00:00:00 2001
From: Rivka Ungar <rivkaun@monday.com>
Date: Wed, 8 Jan 2025 20:52:22 +0200
Subject: [PATCH 2/2] update snapshots

---
 .../__tests__/__snapshots__/Dropdown.snapshot.test.js.snap  | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/packages/core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.snapshot.test.js.snap b/packages/core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.snapshot.test.js.snap
index eb815bfad5..f3dbdfe8ee 100644
--- a/packages/core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.snapshot.test.js.snap
+++ b/packages/core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.snapshot.test.js.snap
@@ -78,7 +78,10 @@ exports[`Dropdown renders correctly snapshot driver should open menu on click if
       </div>
     </div>
     <div
+      aria-label="Dropdown menu"
       class="dropdownMenuWrapper withoutAnimation css-6yg65t-menu"
+      id="dropdown-menu-list-id"
+      role="listbox"
     >
       <div
         class=" css-bknh9q-Component"
@@ -781,7 +784,10 @@ exports[`Dropdown renders correctly snapshot driver should use virtualization if
       </div>
     </div>
     <div
+      aria-label="Dropdown menu"
       class="dropdownMenuWrapper withoutAnimation css-6yg65t-menu"
+      id="dropdown-menu-list-id"
+      role="listbox"
     >
       <div
         class=""