Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain cache key should also include plugin-detected version files #12

Open
Phault opened this issue Feb 18, 2024 · 1 comment
Open
Assignees

Comments

@Phault
Copy link

Phault commented Feb 18, 2024

Most of proto's plugins also tries to resolve the tool version from additional first-party sources such as package.json, .nvmrc, rust-toolchain.toml, etc. In case the resolved version stems from of these files, the file should also be included in the final cache hash.

The easiest route would be adding an additional input for specifying additional sources manually. But it would better if the actually used sources could be retrieved from proto itself, so it just worked automagically.

@milesj
Copy link
Contributor

milesj commented Feb 28, 2024

This is a bit tricky, since we don't know what those version files are without loading and executing every WASM plugin.

I'll see if there's a way to dump this info, but i think that would still happen after the initial key is already hashed.

@milesj milesj self-assigned this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants