Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to make js2-error font face underlined in my setup? #488

Open
redguardtoo opened this issue Mar 7, 2018 · 8 comments
Open

How to make js2-error font face underlined in my setup? #488

redguardtoo opened this issue Mar 7, 2018 · 8 comments

Comments

@redguardtoo
Copy link
Contributor

as title

@dgutov
Copy link
Collaborator

dgutov commented Mar 7, 2018

Try M-x customize-face.

@redguardtoo
Copy link
Contributor Author

Doesn't work, here is the content of my custom-set-variables.el after turning on underlined attribute of js2-error font face:

(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so
 ;; Your init file should contain only one such insta
 ;; If there is more than one, they won't work right.
 '(js2-error ((t (:foreground "red" :underline nil))))

@dgutov
Copy link
Collaborator

dgutov commented Mar 7, 2018

It says :underline nil. Fix that!

@redguardtoo
Copy link
Contributor Author

Still got the issue.

As you can see, console.log('hello') got js-warning face. It's correctly underlined. But qa1('hello') got js-error face but not underlined.

231235-07_1024x768

@dgutov
Copy link
Collaborator

dgutov commented Mar 7, 2018

It works for me.

@redguardtoo
Copy link
Contributor Author

redguardtoo commented Mar 7, 2018

I use Emacs v25.2.2, js2-mode-20180301, on latest debian.
I turn off the color theme but still got the problem.

@dgutov
Copy link
Collaborator

dgutov commented Mar 7, 2018

Have you restarted Emacs since changing the Custom file?

@redguardtoo
Copy link
Contributor Author

redguardtoo commented Mar 8, 2018

Yes, I restarted Emacs several times. I also ran M-x describe-face js2-error and confirmed Underlined is red

Screen
demo
shot of console and GUI emacs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants