Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The negative regex used for class weight calculation may remove content nodes #903

Open
n41l opened this issue Aug 16, 2024 · 0 comments
Open

The negative regex used for class weight calculation may remove content nodes #903

n41l opened this issue Aug 16, 2024 · 0 comments
Labels
maintenance parsing-issue reader-mode-has-issues

Comments

@n41l
Copy link

n41l commented Aug 16, 2024

The /...|hidden|.../i will give a -25 weight for classname likes overflow-hidden which are mostly used by project built with tailwindcss. So maybe /...| hidden |.../i is more suitable for class weight calculation(but may not compatible with id weight).

I also noticed the TODO comment inside the _cleanConditionally function:
// TODO: Consider taking into account original contentScore here.
Is there any plan for this optimization?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance parsing-issue reader-mode-has-issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmkm @n41l