_getJSONLD doesn't handle context objects

[danielnixon]

For example this json-ld from https://www.nbcnews.com/news/world/south-korea-martial-law-president-yoon-suk-yeol-impeachment-vote-rcna183138 fails with Reader: (Readability) [email protected] is not a function:

{
  '@context': {
    '@vocab': 'http://schema.org',
    articleId: { '@id': 'Text', '@type': '@id' },
    topics: { '@id': 'Text', '@type': '@id' }
  },
  '@type': 'NewsArticle',
  headline: 'South Korean president’s impeachment fails after ruling party lawmakers walk out'
  ...
}

The problematic code is this, which assumes parsed["@context"] will always be a string, never an object:

          if (
            !parsed["@context"] ||
            !parsed["@context"].match(/^https?\:\/\/schema\.org$/)
          ) {
            return;
          }

The quick fix to at least avoid the error would be:

          if (
            !parsed["@context"] ||
+           !(typeof parsed["@context"] === "string") ||
            !parsed["@context"].match(/^https?\:\/\/schema\.org$/)
          ) {
            return;
          }

To support objects in addition to strings:

           var content = jsonLdElement.textContent.replace(/^\s*<!\[CDATA\[|\]\]>\s*$/g, "");
           var parsed = JSON.parse(content);
-          if (
-            !parsed["@context"] ||
-            !parsed["@context"].match(/^https?\:\/\/schema\.org$/)
-          ) {
+
+          const schemaDotOrgRegex = /^https?\:\/\/schema\.org$/;
+          const matches =
+            (typeof parsed["@context"] === "string" && parsed["@context"].match(schemaDotOrgRegex)) ||
+            (typeof parsed["@context"] === "object" && typeof parsed["@context"]["@vocab"] == "string" && parsed["@context"]["@vocab"].match(schemaDotOrgRegex))
+
+          if (!matches) {
             return;
           }

[gijsk]

Here too, I'd love to see this in the form of a PR? :-)

[danielnixon]

Thanks @gijsk, here's a PR: #940