You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
None of the maintainers rely on or use the typescript definitions. They were externally contributed and merged; I'd be happy to take pull requests but that would be why the types listed may not be correct.
danielnixon
added a commit
to danielnixon/readability
that referenced
this issue
Jan 3, 2025
The return type in https://github.com/mozilla/readability/blob/main/index.d.ts is misleading. It doesn't include null/undefined in the types of values that can definitely be null or undefined.
byline
, for example, can commonly be null/undefined.This has bitten me a few times while calling Readability from a TypeScript context.
It might be nice if we could update index.d.ts to reflect the types more accurately.
The text was updated successfully, but these errors were encountered: