-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier? #38
Comments
+1 |
@pdehaan I played around with this a bit, but it seems that prettier is so opinionated that it results in eslint errors. If you find a working combination of prettier and eslint rules, I'm all for using prettier (or some other formatter) |
Actually, https://github.com/prettier/prettier-eslint is based on running prettier + eslint --fix and that fixes the eslint issues, so here is a commit that adds npm run format using both prettier and eslint --fix |
This has been addressed in #73 |
Not sure if we care about auto-formatting code. It feels a bit excessive in places, and we have some places which may need tweakin'.
Since we'd be using a nearly identical list of ignores for .prettierignore and .eslintignore, I just stuck with one, but not sure we want to auto-format the package.json file.
The text was updated successfully, but these errors were encountered: