Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier? #38

Closed
pdehaan opened this issue Nov 23, 2017 · 4 comments · Fixed by #73
Closed

Add prettier? #38

pdehaan opened this issue Nov 23, 2017 · 4 comments · Fixed by #73

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Nov 23, 2017

Not sure if we care about auto-formatting code. It feels a bit excessive in places, and we have some places which may need tweakin'.

"format": "prettier '**/*.{css,js,json}' --trailing-comma=all --ignore-path=.eslintignore --write",

Since we'd be using a nearly identical list of ignores for .prettierignore and .eslintignore, I just stuck with one, but not sure we want to auto-format the package.json file.

@motin
Copy link
Contributor

motin commented Feb 13, 2018

+1

@motin
Copy link
Contributor

motin commented Feb 15, 2018

@pdehaan I played around with this a bit, but it seems that prettier is so opinionated that it results in eslint errors. If you find a working combination of prettier and eslint rules, I'm all for using prettier (or some other formatter)

@motin
Copy link
Contributor

motin commented Feb 15, 2018

Actually, https://github.com/prettier/prettier-eslint is based on running prettier + eslint --fix and that fixes the eslint issues, so here is a commit that adds npm run format using both prettier and eslint --fix

@motin
Copy link
Contributor

motin commented Nov 16, 2018

This has been addressed in #73

@motin motin closed this as completed Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants