Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap should also shutdown the webextension component #69

Closed
Standard8 opened this issue May 31, 2018 · 2 comments · Fixed by #73
Closed

Bootstrap should also shutdown the webextension component #69

Standard8 opened this issue May 31, 2018 · 2 comments · Fixed by #73

Comments

@Standard8
Copy link
Member

I was just reviewing some changes elsewhere, and it highlighted to me that the bootstrap.js in this template isn't shutting down the WebExtension component.

For example, this is what screenshots does currently:

https://searchfox.org/mozilla-central/rev/83a923ef7a3b95a516f240a6810c20664b1e0ac9/browser/extensions/screenshots/bootstrap.js#141-148,203

This could cause issues if the add-on is upgraded whilst a study is running. It could also leave the WebExtension part running if the study gets uninstalled.

I don't know how likely it is to cause issues on shutdown or not.

@gregglind
Copy link
Contributor

Thank you for this. We are trying to deprecate master (and legacy) here, and trying to move to WEE's which will have no bootstrap.js files.

See: https://github.com/mozilla/shield-studies-addon-template/tree/develop

@motin
Copy link
Contributor

motin commented Nov 16, 2018

Closing since #73 is merged and we thus are no longer promoting legacy bootstrapped add-ons

@motin motin closed this as completed Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants