Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "world" variable #11

Open
joshuaadickerson opened this issue Feb 27, 2017 · 4 comments
Open

Make "world" variable #11

joshuaadickerson opened this issue Feb 27, 2017 · 4 comments

Comments

@joshuaadickerson
Copy link

Maybe you're saying "hello world", maybe you're saying "hello MPJ". The greetee (what is the right word?) should be variable. That should be injected in the DIC. It should default to "world". The greetee should be added to strings.helloWorld using sprintf-js.

@tiagojdf
Copy link

Yes, but this variable should default not just to world, but to the translation of world, because you don't want to break the translation of hello world for all the international users!

@ngergo6
Copy link

ngergo6 commented Feb 28, 2017

You should also be able to define a template in your translations then. Maybe there are languages where it's [Name] [Greeting] and not [Greeting] [Name].

@rpunkfu
Copy link

rpunkfu commented Feb 28, 2017

Project's own templating language just for this feature haha

@joshuaadickerson
Copy link
Author

@ngergo6 that's the point of using sprintf-js ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants