-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "world" variable #11
Comments
Yes, but this variable should default not just to world, but to the translation of world, because you don't want to break the translation of hello world for all the international users! |
You should also be able to define a template in your translations then. Maybe there are languages where it's |
Project's own templating language just for this feature haha |
@ngergo6 that's the point of using sprintf-js ;) |
Maybe you're saying "hello world", maybe you're saying "hello MPJ". The greetee (what is the right word?) should be variable. That should be injected in the DIC. It should default to "world". The greetee should be added to strings.helloWorld using sprintf-js.
The text was updated successfully, but these errors were encountered: