Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing docker options such as --no-cache #282

Closed
mikkelee opened this issue Oct 11, 2024 · 3 comments
Closed

Passing docker options such as --no-cache #282

mikkelee opened this issue Oct 11, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mikkelee
Copy link

Currently, the docker step of our workflow is just a bunch of commands in a run: |, so I wanted to try updating to this much nicer action instead.

However some of our images require --no-cache, and thus the builds fail. Is it possible to pass such options to the build?

@mr-smithers-excellent mr-smithers-excellent self-assigned this Oct 13, 2024
@mr-smithers-excellent mr-smithers-excellent added the enhancement New feature or request label Oct 13, 2024
@mr-smithers-excellent
Copy link
Owner

What did you have in mind exactly? We could certainly add an input to govern a --no-cache parameter. Can you explain what you mean by "much nicer action"?

@mikkelee
Copy link
Author

Oh, I just meant a proper Github Action is much nicer than handwriting all the docker commands myself :)

We are in the process of converting a number of setups from Travis-CI to Github Actions, and this is one that needs --no-cache. Perhaps others will need other docker options, so the simplest solution might be to just add something like a docker-build-options: input to handle cases like these?

@mikkelee
Copy link
Author

No worries about this, we decided to use docker/build-push-action which has a no-cache input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants