-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:RustLsp renderDiagnostic floating window behavior #603
Comments
Hey 👋 As you mentioned, your first issue is a duplicate of #599, so let's remove that from this issue and adjust the title. Regarding your second issue: The That being said, it's probably worth adding a I'll close this for now. Please feel free to open a PR if you would like the |
BREAKING CHANGE: Running :rustLsp explainError will now only explain error on current line, users are suggested to use vim.diagnostic.goto_prev() and vim.diagnostic.goto_next() for navigation, as stated in issue mrcjkb#603 and mrcjkb#599
BREAKING CHANGE: Running :rustLsp explainError will now only explain error on current line, users are suggested to use vim.diagnostic.goto_prev() and vim.diagnostic.goto_next() for navigation, as stated in issue mrcjkb#603 and mrcjkb#599
BREAKING CHANGE: Running :rustLsp explainError will now only explain error on current line, users are suggested to use vim.diagnostic.goto_prev() and vim.diagnostic.goto_next() for navigation, as stated in issue mrcjkb#603 and mrcjkb#599
Feature description
Hello, I have two issues with the command:
:RustLsp renderDiagnostic
) only cycles forward but not backwards, which is not really convenient and the functionality can be replaced by either nvim's built ins likevim.diagnostic.goto_next()
andvim.diagnostic.goto_prev()
or 3rd party plugins like:Telescope diagnostics
. This is also talked about in Is it possible to cycle to prev instead of next? #599:RustLsp renderDiagnostic current
, it shows up the diagnostic window with a option to "open in split", but running the command again wont focus on the window, and afaik there's now way to actually access the "open in split" menu:For reference, in nvim's built in lsp commands, for example if you press K on a symbol, on the first time it would open up a popup:
and the second time you press it will focus the pop up and allow you to navigate inside the menu:
So I would suggest removing the
cycle
option, and enable users to focus the pop up menu when running the command twice, like many other lsp commands.The text was updated successfully, but these errors were encountered: