Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounding error in date/time conversion #1

Open
msbentley opened this issue Dec 11, 2023 · 0 comments
Open

Rounding error in date/time conversion #1

msbentley opened this issue Dec 11, 2023 · 0 comments

Comments

@msbentley
Copy link
Owner

Reported by user:

I believe I have found a bug in mustlink.py, line 454

data.date = pd.to_datetime(data.date, unit='ms')

Should be

data.date = pd.to_datetime(data.date.astype(int), unit='ms')

Otherwise, I find precision losses in the time conversion (rounding to the closest 1-2 minutes).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msbentley